]> O.S.I.I.S - jp/vkvg.git/commitdiff
Fix CMake policy CMP0175 warning in ADD_CUSTOM_COMMAND
authorColin Lim <44008906+colinrlim@users.noreply.github.com>
Tue, 21 Oct 2025 02:07:12 +0000 (22:07 -0400)
committerColin Lim <44008906+colinrlim@users.noreply.github.com>
Tue, 21 Oct 2025 02:07:12 +0000 (22:07 -0400)
Add explicit POST_BUILD parameter to ADD_CUSTOM_COMMAND at line 227
to comply with CMake policy CMP0175. This eliminates six repeated
warnings during CMake configuration on modern CMake versions.

The command generates shader headers after the BuildShadersHeader
target is built, so POST_BUILD is the appropriate timing.

CMakeLists.txt

index 8fe84d333447eb3336bc0b57962319bb9596ea46..fa585f8df89e9033e00b0f6a3beb4bc85c2e613e 100644 (file)
@@ -223,10 +223,11 @@ IF(GLSLC AND XXD)
        FOREACH(shad_spv ${SHADER_OUTPUTS})
                GET_FILENAME_COMPONENT(SPV ${shad_spv} NAME)
                ADD_CUSTOM_COMMAND (
-                       TARGET BuildShadersHeader
-                       WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${SHADER_DIR}
-                       COMMAND ${XXD} -i ${SPV} >> ${SHADERS_H}
-               )
+            TARGET BuildShadersHeader
+            POST_BUILD
+            WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${SHADER_DIR}
+            COMMAND ${XXD} -i ${SPV} >> ${SHADERS_H}
+        )
        ENDFOREACH()
        SET_SOURCE_FILES_PROPERTIES(${SHADERS_H} PROPERTIES GENERATED 1)
        #add_definitions( -DDEBUG_VK_PERF=true )